This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
website build for julia: fix path to be static #15554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmarkham
force-pushed
the
julia_path_patch
branch
from
4ce8ab1
to
6b85abe
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes the bug in my previous PR for Julia on the website. Third time's a charm. I now have a way to test this all the way through and closer to CI. I moved the logic back to
runtime_functions.shbecause having it in thebuild_all_version.shscript will break regular local testing.This command uses this branch as a source, gets the new config with updated
PATHand in my tests, it now finds Julia in the Docker container.