[Opperf] Filter out deprecated ops #15541
Conversation
|
@mxnet-label-bot add [Benchmark, Operator] |
This reverts commit f8d6f95.
ChaiBapchya
changed the title
| @@ -55,6 +57,11 @@ def _select_ops(operator_names, filters=("_contrib", "_"), merge_op_forward_back | |||
| mx_operators = {} | |||
| operators_with_backward = [] | |||
|
|
|||
| # Filter out deprecated operators | |||
There was a problem hiding this comment.
Is there a "Deprecated" field in the operator metadata?
Because, listing operator by names is not scalable. Everytime we deprecate a operator, we need to come here to add it which soon because un-maintained.
There was a problem hiding this comment.
Did some digging around to find there's no exposed API from backend to retrieve deprecated ops. So at the moment, for the sake of this PR can we go ahead with that. I've created another issue to track the same. Sounds good?
There was a problem hiding this comment.
|
@ChaiBapchya @sandeep-krishnamurthy What's the path forward for this PR ? |
|
As discussed offline with @sandeep-krishnamurthy and @apeforest , this is temporary fix. Given the current bandwidth, temporarily this fix sounds good to go. |
* normal, uniform ops * Revert "normal, uniform ops" This reverts commit f8d6f95. * filter out deprecated ops * Trigger notification * additional deprecated ops * Trigger notification * Trigger notification * Trigger notification
Description
Filters out deprecated operators from
_get_all_mxnet_operators()function.To ensure they are not included while calculating MXNet operators
Current random_sampling_operators supports 16. Added 2 ops (normal, uniform)(although deprecated, they are currently supported. Hence)Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Test/Verify
### How to test/verify ###Build~~ ~~incubator-mxnet$ make -j8~~ ~~incubator-mxnet$ pip install -e python/.~~ ~~Test~~ ~~>>> import mxnet as mx~~ ~~>>> from mxnet import nd ~~ ~~>>> from benchmark.opperf.nd_operations.random_sampling_operators import run_mx_random_sampling_operators_benchmarks~~ ~~>>> print(run_mx_random_sampling_operators_benchmarks())~~ ~~