-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the fix : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! How did we miss this?
Good find! Any test you wrote to verify this?
@mxnet-label-bot add [Operator, pr-awaiting-response] |
@ChaiBapchya We are upgrading MXNet from 1.3 to 1.5 in our deployment env these days and notice some accuracy drop of our models. This bug seems to exist for at least a few months. Maybe we should add more tests to avoid similar bugs in the future. |
Hi @nicklhy , could you please add an unittest in Thank you! |
@nicklhy Great work! Thank you so much! |
* fix normalize mean error bug * add scalar mean/std tests for image_normalize
The normalize operator may produce wrong result when setting the mean arg with a single float val.