Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add AMP Conversion support for BucketingModule #15528

Merged
merged 6 commits into from
Aug 26, 2019

Conversation

anirudh2290
Copy link
Member

Description

  • Add conversion APIs for bucketing module
  • Add support for saving and loading BucketingModule from a checkpoint
  • Add support for loading BucketingModule from a dict of bucket keys to symbols
  • Add tests

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@karan6181
Copy link
Contributor

@mxnet-label-bot add [Module, Python, pr-work-in-progress]

@marcoabreu marcoabreu added Module pr-work-in-progress PR is still work in progress Python labels Jul 15, 2019
@anirudh2290 anirudh2290 marked this pull request as ready for review July 20, 2019 01:07
@anirudh2290 anirudh2290 requested a review from szha as a code owner July 20, 2019 01:07
@anirudh2290 anirudh2290 changed the title [WIP] Add AMP Conversion support for BucketingModule Add AMP Conversion support for BucketingModule Jul 20, 2019
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anirudh2290 anirudh2290 added pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Aug 19, 2019
@anirudh2290 anirudh2290 merged commit acc074f into apache:master Aug 26, 2019
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Module pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants