Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add julia env settings #15523

Merged
merged 1 commit into from
Jul 15, 2019
Merged

add julia env settings #15523

merged 1 commit into from
Jul 15, 2019

Conversation

aaronmarkham
Copy link
Contributor

Description

I missed this env var requirement in the Julia docs PR, #15454.

Comment

We should probably add some CI test for the website publish routine so this kind of thing doesn't get overlooked until after a merge.

@aaronmarkham
Copy link
Contributor Author

Nudging CI since so many tests failed for no apparent reason.

Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcoabreu
Copy link
Contributor

Well do we do have a website staging pipeline. The question here is why your main pipeline differs from the staging pipeline or if there's work that has to be done to migrate the staging one to match the main pipeline.

@aaronmarkham aaronmarkham merged commit 41ecf58 into apache:master Jul 15, 2019
@aaronmarkham
Copy link
Contributor Author

@marcoabreu Can you point me to the staging pipeline so I can review the differences?

@aaronmarkham aaronmarkham mentioned this pull request Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants