Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MKLDNN] Enable subgraph backend mkldnn by default. #15518

Merged
merged 12 commits into from
Jul 26, 2019
Merged

[MKLDNN] Enable subgraph backend mkldnn by default. #15518

merged 12 commits into from
Jul 26, 2019

Conversation

ZhennanQin
Copy link
Contributor

Description

As title.

@pengzhao-intel @TaoLv @ciyongch @anirudh2290

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pengzhao-intel
Copy link
Contributor

@reminisce @zheng-da please help take a review and let us know if you have any concerns.

@ZhennanQin ZhennanQin requested a review from yzhliu as a code owner July 12, 2019 05:13
@karan6181
Copy link
Contributor

@mxnet-label-bot add [MKLDNN, backend, pr-awaiting-review]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet MKLDNN pr-awaiting-review PR is waiting for code review labels Jul 15, 2019
@pengzhao-intel
Copy link
Contributor

cc @zheng-da @reminisce

@pengzhao-intel pengzhao-intel mentioned this pull request Jul 19, 2019
Closed
@pengzhao-intel
Copy link
Contributor

@anirudh2290 would you mind taking a review?

@pengzhao-intel
Copy link
Contributor

@TaoLv @ciyongch @xinyu-intel could you help take a review?

pengzhao-intel
pengzhao-intel approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xinyu-intel
xinyu-intel approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@xinyu-intel xinyu-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel
Copy link
Contributor

Merging now. @MXNet/community Feel free to ping me or @ZhennanQin if there are issues after the PR merging since the default behaviors are changed.

@pengzhao-intel pengzhao-intel merged commit e98fea3 into apache:master Jul 26, 2019
@Zha0q1 Zha0q1 mentioned this pull request Jul 26, 2019
Closed
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@ZhennanQin
[MKLDNN] Enable subgraph backend mkldnn by default. (apache#15518)
3e04330 
* Enable subgraph backend mkldnn by default

* Fix lint

* fix ut

* fix scala test

* Fix UT

* Fix lint

* Run CI

* Run CI

* Support MXNET_MKLDNN_ENABLED

* Fix merge

* Run CI
@ZhennanQin ZhennanQin deleted the subgraph_default branch September 16, 2019 07:00
@ZhennanQin ZhennanQin mentioned this pull request Oct 9, 2019
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

@TaoLv TaoLv TaoLv approved these changes

@xinyu-intel xinyu-intel xinyu-intel approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
Backend Issues related to the backend of MXNet MKLDNN pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZhennanQin @pengzhao-intel @karan6181 @xinyu-intel @TaoLv @marcoabreu