Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix heap-use-after-free in scala #15503

Merged
merged 2 commits into from
Jul 15, 2019
Merged

fix heap-use-after-free in scala #15503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e8d2a
fix heap-use-after-free
arcadiaphy Jul 10, 2019
4e9cba8
trigger CI
arcadiaphy Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scala-package/native/src/main/native/org_apache_mxnet_native_c_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,6 @@ JNIEXPORT jint JNICALL Java_org_apache_mxnet_LibInfo_mxImperativeInvokeEx
cParamVals,
&cOutStypes);
env->ReleaseLongArrayElements(inputs, cInputs, 0);
if (cOutputsGiven) {
env->ReleaseLongArrayElements(outputsGiven, cOutputsGiven, 0);
}

// release allocated memory
if (numParams > 0) {
Expand Down Expand Up @@ -284,6 +281,10 @@ JNIEXPORT jint JNICALL Java_org_apache_mxnet_LibInfo_mxImperativeInvokeEx
}
}

if (cOutputsGiven) {
env->ReleaseLongArrayElements(outputsGiven, cOutputsGiven, 0);
}

return ret;
}

Expand Down