This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Improve diagnose.py, adding build features info and binary library path. #15499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the improvement! LGTM. |
apeforest
suggested changes
Jul 13, 2019
apeforest
approved these changes
Jul 13, 2019
|
One minor comment: the ✖ etc. symbols were not recognized when I import the txt file into MS office or Google Doc. Can we replace these unicode symbols by simple ascii, like Y/N? |
apeforest
previously requested changes
Jul 13, 2019
|
I think they are valid unicode symbols, what problem are you experiencing with MS Office? I think that is out of scope of this PR as it requires changes to the Python code that prints the feature, feel free to send a different PR for that. |
|
@apeforest I don't have any problems with Google docs or Office with those unicode characters. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.
This is the script used to fill issues, so adding more info will help.
Refined output:
diagnose.txt