This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add -DMXNET_USE_OPENMP to Makefiles so runtime info gets updated accordingly #15498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [Installation, Makefile, pr-awaiting-review] |
marcoabreu
added
Installation
Makefile
pr-awaiting-review
access2rohit
approved these changes
Jul 16, 2019
szha
reviewed
Jul 21, 2019
|
This is a bit of a departure of how we are testing since we are not testing depending on specific build flags (other than GPU and CPU which we could remove now thanks to libinfo). In that case we should also do all the permutation builds and check the build flags and also for Make and Cmake. This means adding quite a number of recompilations to test this. I'm not sure is worth the increased cost and trouble. Is it justified for you? |
|
@mxnet-label-bot add Bug |
|
@mxnet-label-bot add [Bug] |
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes OPENMP info in runtime features.
https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/runtime.py
This would be also needed to fix BLAS flags.
#15424