Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Doc] Add MKL install method apt/yum into tutorial #15491

Merged
merged 3 commits into from
Jul 11, 2019

Conversation

xinyu-intel
Copy link
Contributor

Description

#15483
@pengzhao-intel

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@xinyu-intel xinyu-intel requested a review from szha as a code owner July 9, 2019 03:50
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the CI :)

@pengzhao-intel
Copy link
Contributor

cc @TaoLv add this into your document track issue :)

@TaoLv
Copy link
Member

TaoLv commented Jul 9, 2019

Also add apt/yum installation to this page: https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html#math-library-selection?

@TaoLv TaoLv changed the title Add MKL install method apt/yum into tutorial [Doc] Add MKL install method apt/yum into tutorial Jul 9, 2019
@pengzhao-intel
Copy link
Contributor

Thanks, merging now :)

@pengzhao-intel pengzhao-intel merged commit 68460a9 into apache:master Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants