Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Opperf: Support Python<3.6 #15487

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

kshitij12345
Copy link
Contributor

f-Strings are supported only from Python 3.6 onwards.
Have replaced their occurrences with str.format which is supported from Python 2.6.

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address comment by Lin.
Thank you for this contribution.

Co-Authored-By: Lin Yuan <[email protected]>
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kshitij12345 kshitij12345 changed the title Opperf : Support Python<3.6 Opperf: Support Python<3.6 Jul 9, 2019
@wkcn wkcn merged commit d82c89a into apache:master Jul 10, 2019
@wkcn
Copy link
Member

wkcn commented Jul 10, 2019

Merged. Thanks for your contribution!

@kshitij12345 kshitij12345 deleted the opperf/support-python3.5_and_lower branch July 10, 2019 03:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants