Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update profiler.md #15477

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Update profiler.md #15477

merged 1 commit into from
Jul 19, 2019

Conversation

yifeim
Copy link
Contributor

@yifeim yifeim commented Jul 7, 2019

Description

Add one line "dump all results to log file before download" to the main example. Otherwise, it is likely that a user may download partially-written and broken files.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Add one line "dump all results to log file before download" to the main example. Otherwise, it is likely that a user may download partially-written and broken files.
@yifeim yifeim requested a review from szha as a code owner July 7, 2019 00:26
@roywei
Copy link
Member

roywei commented Jul 8, 2019

@mxnet-label-bot add [doc]

@marcoabreu marcoabreu added the Doc label Jul 8, 2019
@karan6181
Copy link
Contributor

@szha Could you please review this PR? Thanks!

@szha szha merged commit d14fa69 into apache:master Jul 19, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Add one line "dump all results to log file before download" to the main example. Otherwise, it is likely that a user may download partially-written and broken files.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants