Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-978] Higher Order Gradient Support sqrt, cbrt. #15474

Merged
merged 5 commits into from
Sep 6, 2019
Merged

[MXNET-978] Higher Order Gradient Support sqrt, cbrt. #15474

merged 5 commits into from
Sep 6, 2019

Conversation

kshitij12345
Copy link
Contributor

Description

PR intends to add support for higher order gradient for sqrt, cbrt.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA-978 issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • higher order gradient for a sqrt, cbrt.
  • unit test for the same.

@roywei
Copy link
Member

roywei commented Jul 8, 2019

@mxnet-label-bot add [pr-awaiting-review, Backend, Operator]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet Operator pr-awaiting-review PR is waiting for code review labels Jul 8, 2019
@apeforest apeforest self-requested a review July 10, 2019 22:11
apeforest
apeforest approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karan6181
Copy link
Contributor

@kshitij12345 is this PR good to go for merge?

@kshitij12345
Copy link
Contributor Author

As of now there are no changes with this PR. However I would like to know @apeforest opinion on #15531. If that is approved, I'll make changes in all other PR to use the machinery introduced by it.

@piyushghai
Copy link
Contributor

@kshitij12345 Can you rebase with the latest master and then this PR will be good to go :)

@roywei
Copy link
Member

roywei commented Aug 19, 2019

@kshitij12345 gentle ping to rebase so we can merge, thanks!

@kshitij12345
Copy link
Contributor Author

@roywei Have retriggered and successfully run.

@apeforest apeforest merged commit c928392 into apache:master Sep 6, 2019
@kshitij12345 kshitij12345 deleted the develop/add-higher-order/sqrt-cbrt branch September 7, 2019 06:43
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
@kshitij12345 @gyshi
[MXNET-978] Higher Order Gradient Support sqrt, cbrt. (apache#15474)
b0621b2 
* support sqrt, cbrt for higher order grad

* add relevant tests

* remove unnecessary variable
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
@kshitij12345 @gyshi
[MXNET-978] Higher Order Gradient Support sqrt, cbrt. (apache#15474)
3310def 
* support sqrt, cbrt for higher order grad

* add relevant tests

* remove unnecessary variable
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@kshitij12345 @larroy
[MXNET-978] Higher Order Gradient Support sqrt, cbrt. (apache#15474)
1cd94cb 
* support sqrt, cbrt for higher order grad

* add relevant tests

* remove unnecessary variable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apeforest apeforest apeforest approved these changes

Assignees
No one assigned
Labels
Backend Issues related to the backend of MXNet Operator pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kshitij12345 @roywei @karan6181 @piyushghai @apeforest @marcoabreu