Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update fp16 docs: Block.cast is inplace #15458

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Conversation

Kh4L
Copy link
Contributor

@Kh4L Kh4L commented Jul 4, 2019

Signed-off-by: Serge Panev [email protected]

Description

Update fp16 docs: Block.cast is inplace

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Doc, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Kh4L Kh4L requested a review from szha as a code owner July 4, 2019 06:34
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! LGTM

@szha szha merged commit dfe923a into apache:master Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants