Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix nightly CI failure #15452

Merged
merged 3 commits into from
Jul 12, 2019
Merged

fix nightly CI failure #15452

merged 3 commits into from
Jul 12, 2019

Conversation

roywei
Copy link
Member

@roywei roywei commented Jul 3, 2019

should fix:
(1) #15374
Nightly test on amp tutorial is still failing after reverting the large tensor PR due to new change on the tutorial in #15118 requires np.float32


------------------



---------------------------------------------------------------------------

NameError                                 Traceback (most recent call last)

<ipython-input-11-7f79a6994fc9> in <module>

      9     # Run dummy inference with the converted gluon model

     10     result = converted_model.forward(mx.nd.random.uniform(shape=(1, 3, 224, 224),

---> 11                                                           dtype=np.float32))

     12 

     13     # Below is an example of converting a symbolic model to a mixed precision model



NameError: name 'np' is not defined

NameError: name 'np' is not defined

(2) #15199
using fixed seed to reduce flakiness in accuracy assertion.

@roywei roywei requested a review from szha as a code owner July 3, 2019 15:58
@roywei
Copy link
Member Author

roywei commented Jul 4, 2019

cc @lebeg @apeforest @anirudh2290

@@ -253,6 +253,8 @@ def test_estimator_gpu(**kwargs):
test_dataloader = gluon.data.DataLoader(test_set, batch_size)

# Model
# using fixed seed to reduce flakiness in accuracy assertion
mx.random.seed(7)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be done here. there's a decorator with_seed for this purpose

@roywei
Copy link
Member Author

roywei commented Jul 8, 2019

@mxnet-label-bot add [CI, test]

@lebeg
Copy link
Contributor

lebeg commented Jul 11, 2019

@roywei could you apply changes that @szha requested? The nightly tests are still broken.

@roywei
Copy link
Member Author

roywei commented Jul 12, 2019

I have verified test_estimator passed. but test tutorials is still failing due to other tutorials are failing. This change is needed nonetheless

----------------------------------------------------------------------
Ran 2 tests in 341.805s

OK
build.py: 2019-07-12 01:33:11,865Z INFO Waiting for status of container 594316b5c329 for 600 s.
build.py: 2019-07-12 01:33:12,139Z INFO Container exit status: {'Error': None, 'StatusCode': 0}
build.py: 2019-07-12 01:33:12,139Z INFO Container exited with success 👍
build.py: 2019-07-12 01:33:12,140Z INFO Stopping container: 594316b5c329
build.py: 2019-07-12 01:33:12,141Z INFO Removing container: 594316b5c329

@anirudh2290 anirudh2290 merged commit 2565fa2 into apache:master Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants