Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Upgrade MKL-DNN submodule to v0.20 release #15422

Merged
merged 5 commits into from
Jul 9, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Jul 1, 2019

Description

https://github.com/intel/mkl-dnn/releases/tag/v0.20

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jul 1, 2019
@TaoLv TaoLv requested a review from anirudh2290 as a code owner July 2, 2019 03:05
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoLv is this ready to go?

@roywei
Copy link
Member

roywei commented Jul 8, 2019

@mxnet-label-bot add [MKLDNN]

@TaoLv
Copy link
Member Author

TaoLv commented Jul 8, 2019

I think it's good to merge now. :)

@pengzhao-intel
Copy link
Contributor

Thanks for the contribution. Merging now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
MKLDNN pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants