This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-978] Higher Order Gradient Support sinh, cosh.
#15412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
changed the title
sinh, cosh.sinh, cosh.
|
@mxnet-label-bot add [pr-awaiting-review] |
…to develop/add-higher-order/sinh-cosh
…to develop/add-higher-order/sinh-cosh
|
@apeforest Could you please review the PR? Thanks! |
apeforest
reviewed
Jul 19, 2019
| @@ -92,7 +92,7 @@ The storage type of ``cos`` output is always dense | |||
| MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU(_backward_cos, unary_bwd<mshadow_op::cos_grad>) | |||
| .set_attr<nnvm::FGradient>("FGradient", | |||
| [](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) { | |||
| // ograds[0]: head_grad_grads (dL/dx_grad) | |||
| // ograds[0]: head_grad_grads (dL/dy_grad) | |||
There was a problem hiding this comment.
Why change this? I think the original dL/dx_grad is correct.
There was a problem hiding this comment.
Please have a look and let me know what you think.
#15331 (comment)
apeforest
reviewed
Jul 19, 2019
| @@ -49,7 +49,7 @@ The storage type of ``sin`` output depends upon the input storage type: | |||
| MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU_DR(_backward_sin, unary_bwd<mshadow_op::sin_grad>) | |||
| .set_attr<nnvm::FGradient>("FGradient", | |||
| [](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) { | |||
| // ograds[0]: head_grad_grads (dL/dxgrad) | |||
| // ograds[0]: head_grad_grads (dL/dy_grad) | |||
There was a problem hiding this comment.
Why change this? I think the original dL/dx_grad is correct.
apeforest
reviewed
Jul 19, 2019
| MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU_DR(_backward_sinh, unary_bwd<mshadow_op::sinh_grad>) | ||
| .set_attr<nnvm::FGradient>("FGradient", | ||
| [](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) { | ||
| // ograds[0]: dL/dy_grad |
There was a problem hiding this comment.
Why change this? I think the original dL/dx_grad is correct.
apeforest
reviewed
Jul 19, 2019
| MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU(_backward_cosh, unary_bwd<mshadow_op::cosh_grad>) | ||
| .set_attr<nnvm::FGradient>("FGradient", | ||
| [](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) { | ||
| // ograds[0]: dL/dy_grad |
There was a problem hiding this comment.
Why change this? I think the original dL/dx_grad is correct.
kshitij12345
force-pushed
the
develop/add-higher-order/sinh-cosh
branch
from
95cadc1
to
794eefd
Compare
…to develop/add-higher-order/sinh-cosh
|
@kshitij12345 is this PR good to go for merge? |
|
I guess we should wait till #15531 is in. |
|
@larroy @apeforest Gentle ping for review. |
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* add higher order support for sinh cosh * add relevant tests * update comments * retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR intends to add support for higher order gradient for
sinh,cosh.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
sinh,cosh.