Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix memory leak in NaiveEngine #15405

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Fix memory leak in NaiveEngine #15405

merged 2 commits into from
Jul 4, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Jun 29, 2019

Fixes #15375

Description

Fixes a memory leak in NaiveEngine when using operator profiling.

@larroy
Copy link
Contributor Author

larroy commented Jun 29, 2019

Added valgrind run which shows the memory being leaked.

naive_engine_leak

@larroy
Copy link
Contributor Author

larroy commented Jun 29, 2019

@mxnet-label-bot add [Engine, Bug, Memory]

@larroy
Copy link
Contributor Author

larroy commented Jun 29, 2019

@mxnet-label-bot add [Backend]

@marcoabreu marcoabreu added the Backend Issues related to the backend of MXNet label Jun 29, 2019
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the fix!

@larroy
Copy link
Contributor Author

larroy commented Jul 3, 2019

@mxnet-label-bot add [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jul 3, 2019
@wkcn wkcn merged commit faccc59 into apache:master Jul 4, 2019
@wkcn
Copy link
Member

wkcn commented Jul 4, 2019

Merged. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backend Issues related to the backend of MXNet Bug Memory pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in Naive engine when profiling
3 participants