Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add a new arange_like operator to contrib #15400

Merged
merged 6 commits into from
Jul 6, 2019
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion src/operator/tensor/init_op.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ DMLC_REGISTER_PARAMETER(InitOpParam);
DMLC_REGISTER_PARAMETER(InitOpWithScalarParam);
DMLC_REGISTER_PARAMETER(InitOpWithoutDTypeParam);
DMLC_REGISTER_PARAMETER(RangeParam);
DMLC_REGISTER_PARAMETER(RangeLikeParam);
DMLC_REGISTER_PARAMETER(EyeParam);
DMLC_REGISTER_PARAMETER(LinspaceParam);

Expand Down Expand Up @@ -97,9 +98,44 @@ NNVM_REGISTER_OP(_arange)
.set_attr_parser(RangeParamParser)
.set_attr<mxnet::FInferShape>("FInferShape", RangeShape)
.set_attr<nnvm::FInferType>("FInferType", InitType<RangeParam>)
.set_attr<FCompute>("FCompute<cpu>", RangeCompute<cpu>)
.set_attr<FCompute>("FCompute<cpu>", RangeCompute<cpu, RangeParam>)
.add_arguments(RangeParam::__FIELDS__());

NNVM_REGISTER_OP(_contrib_arange_like)
.describe(R"code(Return an array with evenly spaced values. If axis is not given, the output will
have the same shape as the input array. Otherwise, the output will be a 1-D array with size of
the specified axis in input shape.

Examples::

x = [[0.14883883 0.7772398 0.94865847 0.7225052 ]
[0.23729339 0.6112595 0.66538996 0.5132841 ]
[0.30822644 0.9912457 0.15502319 0.7043658 ]]
<NDArray 3x4 @cpu(0)>

out = mx.nd.contrib.arange_like(x, start=0)

[[ 0. 1. 2. 3.]
[ 4. 5. 6. 7.]
[ 8. 9. 10. 11.]]
<NDArray 3x4 @cpu(0)>

out = mx.nd.contrib.arange_like(x, start=0, axis=-1)

[0. 1. 2. 3.]
<NDArray 4 @cpu(0)>
)code")
.set_num_inputs(1)
.set_num_outputs(1)
.set_attr_parser(ParamParser<RangeLikeParam>)
.set_attr<mxnet::FInferShape>("FInferShape", RangeLikeShape)
.set_attr<nnvm::FInferType>("FInferType", InitType<RangeLikeParam, 1>)
.set_attr<nnvm::FIgnoreInputs>("FIgnoreInputs",
[](const NodeAttrs& attrs) { return std::vector<uint32_t>(1, 0); })
.set_attr<FCompute>("FCompute<cpu>", RangeCompute<cpu, RangeLikeParam>)
.set_attr<nnvm::FGradient>("FGradient", MakeZeroGradNodes)
.add_argument("data", "NDArray-or-Symbol", "The input");

NNVM_REGISTER_OP(_linspace)
.describe("Return evenly spaced numbers over a specified interval. Similar to Numpy")
.set_num_inputs(0)
Expand Down
5 changes: 4 additions & 1 deletion src/operator/tensor/init_op.cu
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ NNVM_REGISTER_OP(_full)
.set_attr<FCompute>("FCompute<gpu>", InitFillWithScalarCompute<gpu>);

NNVM_REGISTER_OP(_arange)
.set_attr<FCompute>("FCompute<gpu>", RangeCompute<gpu>);
.set_attr<FCompute>("FCompute<gpu>", RangeCompute<gpu, RangeParam>);

NNVM_REGISTER_OP(_contrib_arange_like)
.set_attr<FCompute>("FCompute<gpu>", RangeCompute<gpu, RangeLikeParam>);

NNVM_REGISTER_OP(_linspace)
.set_attr<FCompute>("FCompute<gpu>", LinspaceCompute<gpu>);
Expand Down
64 changes: 60 additions & 4 deletions src/operator/tensor/init_op.h
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,40 @@ struct RangeParam : public dmlc::Parameter<RangeParam> {
}
};

struct RangeLikeParam : public dmlc::Parameter<RangeLikeParam> {
double start;
double step;
int repeat;
std::string ctx;
int dtype;
dmlc::optional<int> axis;

DMLC_DECLARE_PARAMETER(RangeLikeParam) {
DMLC_DECLARE_FIELD(start)
.set_default(0)
.describe("Start of interval. The interval includes this value. The default start value is 0.");
DMLC_DECLARE_FIELD(step)
.set_default(1)
.describe("Spacing between values.");
DMLC_DECLARE_FIELD(repeat)
.set_default(1)
.describe("The repeating time of all elements."
" E.g repeat=3, the element a will be repeated three times --> a, a, a.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to know how the repeat parameter work with:
https://github.com/apache/incubator-mxnet/blob/35db8e5a4719335a8974f2a8198a44e814fedaa0/src/operator/tensor/init_op.h#L494-L499
and there is not repeat parameter on the numpy.arange().

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately nd.arange has a different interface compard to numpy.arange. I think it's reasonable to let contrib.arange_like have an interface similar to nd.arange.
If we want to remove the repeat argument, it's best when we add the arange op to the mx.np namespace in the numpy project.

@haojin2 @reminisce FYI the nd.arange operator interface is inconsistent with numpy

DMLC_DECLARE_FIELD(ctx)
.set_default("")
.describe("Context of output, in format [cpu|gpu|cpu_pinned](n)."
"Only used for imperative calls.");
DMLC_DECLARE_FIELD(dtype).set_default(mshadow::kFloat32)
MXNET_ADD_ALL_TYPES
.describe("Target data type.");
DMLC_DECLARE_FIELD(axis)
.set_default(dmlc::optional<int>())
.describe("Arange elements according to the size of a certain axis of input array."
" The negative numbers are interpreted counting from the backward."
" If not provided, will arange elements according to the input shape.");
}
};

/*! \brief Initialize and fill output with an arbitrary value */
struct InitOpWithScalarParam : dmlc::Parameter<InitOpWithScalarParam> {
mxnet::TShape shape;
Expand Down Expand Up @@ -250,12 +284,12 @@ inline bool InitShape(const nnvm::NodeAttrs& attrs,
return shape_is_known(out_attrs->at(0));
}

template<typename ParamType>
template<typename ParamType, int inum = 0U>
eric-haibin-lin marked this conversation as resolved.
Show resolved Hide resolved
inline bool InitType(const nnvm::NodeAttrs& attrs,
std::vector<int> *in_attrs,
std::vector<int> *out_attrs) {
const ParamType& param = nnvm::get<ParamType>(attrs.parsed);
CHECK_EQ(in_attrs->size(), 0U);
CHECK_EQ(in_attrs->size(), inum);
CHECK_EQ(out_attrs->size(), 1U);
TYPE_ASSIGN_CHECK(*out_attrs, 0, param.dtype);
return true;
Expand Down Expand Up @@ -493,15 +527,15 @@ struct range_fwd {
}
};

template<typename xpu>
template<typename xpu, typename ParamType>
void RangeCompute(const nnvm::NodeAttrs& attrs,
const OpContext& ctx,
const std::vector<TBlob>& inputs,
const std::vector<OpReqType>& req,
const std::vector<TBlob>& outputs) {
using namespace mxnet_op;
Stream<xpu> *s = ctx.get_stream<xpu>();
const RangeParam& param = nnvm::get<RangeParam>(attrs.parsed);
const ParamType& param = nnvm::get<ParamType>(attrs.parsed);
MSHADOW_TYPE_SWITCH(outputs[0].type_flag_, DType, {
// Force unsigned params to take two's complement form on ARM to ensure consistency with x86
// results. Casting negative floats to unsigned types is undefined in the CPP standard.
Expand Down Expand Up @@ -588,6 +622,28 @@ inline bool LinspaceShape(const nnvm::NodeAttrs& attrs,
return true;
}

inline bool RangeLikeShape(const nnvm::NodeAttrs& attrs,
mxnet::ShapeVector *in_attrs,
mxnet::ShapeVector *out_attrs) {
const RangeLikeParam& param = nnvm::get<RangeLikeParam>(attrs.parsed);
eric-haibin-lin marked this conversation as resolved.
Show resolved Hide resolved
CHECK_EQ(in_attrs->size(), 1U);
CHECK_EQ(out_attrs->size(), 1U);
int real_axis = -1;
if (param.axis.has_value()) {
real_axis = param.axis.value() < 0 ?
(param.axis.value() + (*in_attrs)[0].ndim()) : param.axis.value();
CHECK(real_axis >=0 && real_axis < (*in_attrs)[0].ndim())
<< "cannot handle param.axis " << param.axis.value() << ".";
}
if (real_axis == -1) {
SHAPE_ASSIGN_CHECK(*out_attrs, 0, (*in_attrs)[0]);
} else {
const index_t out_size = (*in_attrs)[0][real_axis];
SHAPE_ASSIGN_CHECK(*out_attrs, 0, mxnet::TShape({static_cast<nnvm::dim_t>(out_size)}));
}
return true;
}

} // namespace op
} // namespace mxnet

Expand Down
11 changes: 11 additions & 0 deletions tests/python/unittest/test_operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -4041,11 +4041,22 @@ def test_arange_inferstop():
exe.forward()
assert_almost_equal(exe.outputs[0].asnumpy(), np.array([0,1,2,3,4]))

def test_arange_like():
shape_list = [(10,), (10, 20), (10, 20, 30), (10, 20, 30, 40)]
axis = 0
eric-haibin-lin marked this conversation as resolved.
Show resolved Hide resolved
for sh in shape_list:
val = np.random.rand(*sh)
data = mx.nd.array(val)
nd_out = mx.nd.contrib.arange_like(data, start=0, axis=axis)
np_out = np.arange(start=0, stop=sh[axis])
assert_almost_equal(nd_out.asnumpy(), np_out)

test_basic_val_init(mx.sym.zeros, np.zeros, (3, 4), np.float32)
test_basic_val_init(mx.sym.ones, np.ones, 3, np.int32)
test_basic_val_init(mx.sym.ones, np.ones, (2, 2, 3), np.float16)
test_arange()
test_arange_inferstop()
test_arange_like()


@with_seed()
Expand Down