This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is some unnecessary complexity in the shorthand aliasing scheme this work aims to correct. We expect
mx->nd->array(...)
andAI::MXNet::NDArray->array(...)
to be functionally equivalent and they are, but there are edge cases where the methods supported by the short and long names don't exactly align.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
AUTOLOAD
rather than dynamic method creation to avoid namespace collisions between class and function names. For example,AI::MXNet::Context
the class vs.AI::MXNet->Context()
the shorthand forAI::MXNet::Context->new()
.register()
methods to not mangle stack traces.Comments
AI::MXNet::Gluon::Block->register()
to use theAUTOLOAD
scheme even though it seems to need the same class vs. method collision avoidance as in other places. Hopefully this can be dealt with in a future effort.