Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add Sparse NDArray support for Scala #15378

Merged
merged 6 commits into from
Jul 8, 2019
Merged

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Jun 27, 2019

Description

This is the initial PR to start supporting Sparse NDArray for the Scala package.

SparseNDArray is a child class of MXNet NDArray. It supports the following types:

  • row sparse
  • CSR

Currently, users can call toSparse method to convert a NDArray from dense to sparse or cast a NDArray to SparseNDArray. User can also call the following two methods to create Sparse NDArray from scratch

  • SparseNDArray.csrMatrix
  • SparseNDArray.rowSparseArray

@gigasquid @zachgk @yzhliu @nswamy @eric-haibin-lin @frankfliu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@@ -45,6 +45,22 @@ class NDArraySuite extends FunSuite with BeforeAndAfterAll with Matchers {
assert(ndones.toScalar === 1f)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also test ndarray iterator with csr_matrix?

@lanking520 lanking520 merged commit 09c71bf into apache:master Jul 8, 2019
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Aug 19, 2019
* add Sparse Support

* add imperative invoke sparse support

* add retain method and comments

* add getData method

* add Sparse NDIter test

* remove debug line
@lanking520 lanking520 deleted the sparse branch September 27, 2019 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants