Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy compatible eye #15282

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Numpy compatible eye #15282

merged 1 commit into from
Jul 12, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Jun 19, 2019

Description

Numpy compatible eye

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@haojin2 @reminisce

@stu1130 stu1130 requested a review from szha as a code owner June 19, 2019 22:28
@Roshrini Roshrini added Operator pr-awaiting-review PR is waiting for code review labels Jun 23, 2019
@haojin2 haojin2 added the Numpy label Jun 27, 2019
@haojin2
Copy link
Contributor

haojin2 commented Jul 10, 2019

@stu1130 Please rebase and resolve conflict when you have time, thx

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @reminisce can double check.

address the comment
@haojin2 haojin2 merged commit 3ea5f8c into apache:numpy Jul 12, 2019
reminisce pushed a commit to reminisce/mxnet that referenced this pull request Jul 17, 2019
address the comment
haojin2 pushed a commit that referenced this pull request Jul 18, 2019
address the comment
haojin2 pushed a commit that referenced this pull request Jul 19, 2019
address the comment
haojin2 pushed a commit to haojin2/incubator-mxnet that referenced this pull request Jul 22, 2019
address the comment
haojin2 pushed a commit that referenced this pull request Jul 23, 2019
address the comment
haojin2 pushed a commit that referenced this pull request Jul 24, 2019
address the comment
haojin2 pushed a commit that referenced this pull request Jul 26, 2019
address the comment
reminisce pushed a commit to reminisce/mxnet that referenced this pull request Aug 1, 2019
address the comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Numpy Operator pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants