Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DOC] Clarify that global pooling is going to reset padding #15269

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Jun 18, 2019

This behaviour changed from older MXNet versions in which global pooling
would consider padding. This clarifies the user documentation.

See also #14421

@aaronmarkham

This behaviour changed from older MXNet versions in which global pooling
would consider padding. This clarifies the user documentation.

See also apache#14421
@larroy
Copy link
Contributor Author

larroy commented Jun 18, 2019

@mxnet-label-bot add [doc,pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels Jun 18, 2019
@larroy
Copy link
Contributor Author

larroy commented Jun 24, 2019

@szha

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larroy
Copy link
Contributor Author

larroy commented Jun 26, 2019

@mxnet-label-bot update [Doc, pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Jun 26, 2019
@aaronmarkham
Copy link
Contributor

@larroy Please ask another person to review... then I can merge it.

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aaronmarkham aaronmarkham merged commit ba30644 into apache:master Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants