Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Make MXNDArrayFromDLPack backward compatible #15227

Merged
merged 7 commits into from
Jun 13, 2019

Conversation

anirudh2290
Copy link
Member

@anirudh2290 anirudh2290 commented Jun 12, 2019

Description

Make MXNDArrayFromDLPack backward compatible, and add an additional Ex API.
Add backward compatibility tests.

@junrushao1994 @roywei @szha

This will need to go in 1.5 branch.

Thanks to @frankfliu for pointing this.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@wkcn wkcn added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jun 13, 2019
@szha szha merged commit a862270 into apache:master Jun 13, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Upgrade archive utility and add back FC improvement

This reverts commit 6543488.

* Make MXNDArrayFromDLPack C API backward compatible

* Fix to comment

* Add tests for dlpack

* Revert "Upgrade archive utility and add back FC improvement"

This reverts commit 40beeb2.

* Fix C API call
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants