This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Opperf] Make module/namespace of the operator parameterized #15226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep-krishnamurthy
added
Benchmark
Operator
pr-awaiting-review
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
sandeep-krishnamurthy
force-pushed
the
opperf_extension
branch
from
5691b78
to
aa51644
Compare
|
@apeforest - Thanks for your review. Addressed your comments. Sorry for the delay. |
apeforest
reviewed
Jun 28, 2019
apeforest
approved these changes
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an extension from the PR - #14977
Addressing comments raised by @apeforest - Making module / namespace of operator as a single global parameter. This will allow running for mx.nd or mx.np for all operator benchmark with one single line change.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
@apeforest