Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Bugfix: accept NN as an inter_method for augmentation in ImageRecordI… #15221

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

cesans
Copy link
Contributor

@cesans cesans commented Jun 12, 2019

Description

Minor bugfix, resolves #15214

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@cesans
Copy link
Contributor Author

cesans commented Jun 12, 2019

Pinging @zhreshold @zachgk

@piyushghai
Copy link
Contributor

@anirudhacharya Can you also have a look at this ?

Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@zhreshold zhreshold merged commit 027b547 into apache:master Jun 12, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
apache#15221)

* Bugfix: accept NN as an inter_method for augmentation in ImageRecordIter and ImageDetRecordIter

* Unittest: all valid inter_methods can be used
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageRecordIter interpolation method (inter_method) fails for NN (0)
3 participants