Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Readd Java HelloWorld example for intellij tutorial #15217

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Jun 12, 2019

Description

This PR adds back the java HelloWorld demo that was removed as part of #14213 to fix the intellij on java tutorial. It also fixes the reference to the new location in the tutorial and includes a fix to the dot call.
resolves #15204
@lanking520 @aaronmarkham

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk added Doc Java Label to identify Java API component labels Jun 12, 2019
@lanking520 lanking520 merged commit 29fea48 into apache:master Jun 12, 2019
@@ -123,7 +123,7 @@ Click "Import Changes" in this prompt.
**Step 5.** Build the project:
- To build the project, from the menu choose Build, and then choose Build Project.

**Step 6.** Navigate to the App.java class in the project and paste the code in `main` method from HelloWorld.java from [Java Demo project](https://github.com/apache/incubator-mxnet/blob/java-api/scala-package/mxnet-demo/java-demo/src/main/java/sample/HelloWorld.java) on MXNet repository, overwriting the original hello world code.
**Step 6.** Navigate to the App.java class in the project and paste the code in `main` method from HelloWorld.java from [Java Demo project](https://github.com/apache/incubator-mxnet/blob/java-api/scala-package/mxnet-demo/java-demo/src/main/java/mxnet/HelloWorld.java) on MXNet repository, overwriting the original hello world code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachgk @lanking520 This url still gives a 404. ( https://github.com/apache/incubator-mxnet/blob/java-api/scala-package/mxnet-demo/java-demo/src/main/java/mxnet/HelloWorld.java)
This refers to a tree java-api which was deleted after that branch was merged into master.
The tree location needs to be changed to master

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc Java Label to identify Java API component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java hello world demo is missing
3 participants