This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fixed a bug in Gluon DataLoader. #15195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: apache#15025 Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
|
@mxnet-label-bot add [Gluon, Data-loading, pr-awaiting-review] @chandana1332 Please add "Fixes #15025" in the PR description to automatically close the issue when this PR is merged. |
marcoabreu
added
Data-loading
Gluon
pr-awaiting-review
|
@vandanavk Done! |
zhreshold
suggested changes
Jun 11, 2019
| @@ -409,7 +409,7 @@ def _thread_worker_fn(samples, batchify_fn, dataset): | |||
| class _MultiWorkerIter(object): | |||
| """Internal multi-worker iterator for DataLoader.""" | |||
| def __init__(self, worker_pool, batchify_fn, batch_sampler, pin_memory=False, | |||
| pin_device_id=0, worker_fn=_worker_fn, prefetch=0, dataset=None): | |||
| pin_device_id=0, worker_fn=_worker_fn, prefetch=0, dataset=None, dataloader=None): | |||
There was a problem hiding this comment.
nit: dataloader-> data_loader ?
Issue: apache#15025 Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
Issue: apache#15025 Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
Issue: apache#15025 Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
zhreshold
approved these changes
Jun 11, 2019
|
Merged. Thank you for the fix! |
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Fixed a bug in Gluon DataLoader.
Issue: apache#15025
Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
* Fixed a bug in Gluon DataLoader.
Issue: apache#15025
Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
* Fixed a bug in Gluon DataLoader.
Issue: apache#15025
Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
* Fixed a bug in Gluon DataLoader.
Issue: apache#15025
Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15025
Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
Description
Fixes #15025
Bug: Gluon DataLoader terminates the process pool early while _MultiWorkerIter is operating on the pool.
Cause: https://github.com/apache/incubator-mxnet/pull/13537/files
As seen in the patch, the process pool is terminated when DataLoader is garbage collected but the scope of the process pool goes beyond the DataLoader until _MultiWorkerIter
Fix: Broadened the scope of worker pool to iterators. Passed a reference of dataloader to the multi worker iterator
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments