Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add 'asnumpy' dtype option to check_symbolic_backward #15186

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Jun 8, 2019

Description

As title. Will enable easier testing for operators with inputs of different data types

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add asnumpy option for check_symbolic_backward test util

Comments

Locally tested on some ops with mixed input data types.

@haojin2 haojin2 requested a review from szha June 8, 2019 00:20
@haojin2 haojin2 added the Test label Jun 8, 2019
@haojin2 haojin2 self-assigned this Jun 8, 2019
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@wkcn wkcn added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jun 23, 2019
@wkcn wkcn merged commit cd19367 into apache:master Jun 28, 2019
@wkcn
Copy link
Member

wkcn commented Jun 28, 2019

Merged. Thank you : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants