Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix a bug in Auto Function. #15184

Merged
merged 3 commits into from
Jun 8, 2019
Merged

Conversation

zheng-da
Copy link
Contributor

@zheng-da zheng-da commented Jun 7, 2019

Description

This PR is to fix this issue: #15183
The callback function delete_entry is invoked in the CAPI. In the original code, the callback function may be invoked before the context is registered. So we need to switch this two lines to make sure the context has been registered.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@piyushghai
Copy link
Contributor

piyushghai commented Jun 7, 2019

@mxnet-label-bot Add [Autograd, pr-awaiting-review]

@marcoabreu marcoabreu added Autograd pr-awaiting-review PR is waiting for code review labels Jun 7, 2019
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR description

@szha szha merged commit c5874dd into apache:master Jun 8, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* add test.

* fix.

* update test.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Autograd pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants