Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1416] Fix inception inference example for potential index out of range error. #15179

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

leleamol
Copy link
Contributor

@leleamol leleamol commented Jun 7, 2019

Description

Fix inception inference example for potential index out of range error. The PR also adds a helper method in NDArray to retrieve the elements from 1 D array.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [y] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [y] Changes are complete (i.e. I finished coding on this PR)
  • [y] All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [y] Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@piyushghai
Copy link
Contributor

Thanks for your contributions @leleamol
@mxnet-label-bot Add [pr-awaiting-review, C++]

@marcoabreu marcoabreu added C++ Related to C++ pr-awaiting-review PR is waiting for code review labels Jun 7, 2019
Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leleamol
Copy link
Contributor Author

leleamol commented Jun 7, 2019

@lanking520 Can we get this PR merged?

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The At method looks a little bit strange and only limited to a certain dimensional array. Since it is defined as a default, LGTM.

@lanking520 lanking520 merged commit 745a41c into apache:master Jun 7, 2019
@leleamol leleamol deleted the fix-cpp-example branch June 10, 2019 18:10
@leleamol
Copy link
Contributor Author

@mxnet-label-bot remove [pr-awaiting-review]

@marcoabreu marcoabreu removed the pr-awaiting-review PR is waiting for code review label Jun 10, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…of range error. (apache#15179)

* Adding support to get the data from 1D NDArray.

* Added the error handling for index out of range.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C++ Related to C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants