This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1414]fix gradient bug of boolean mask #15175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue: #15172
Hi, there.
The operator
mx.nd.contrib.boolean_mask
gives the wrong gradient.I have fixed it and add a unittest.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comment
In the CPU backward of boolean mask, it uses
BooleanMaskBackwardCPUWriteKernel
kernel to accelerate when req isWriteTo
.