Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix Scala release #15155

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Fix Scala release #15155

merged 2 commits into from
Jun 7, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Jun 5, 2019

Add GPG signing to pom.xml through additional externalPom module
Fix staging target repository

@lanking520 @frankfliu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Add GPG signing to pom.xml
Fix staging target repository
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this

scala-package/externalPom/pom.xml Outdated Show resolved Hide resolved
@zachgk zachgk requested a review from lanking520 June 5, 2019 21:25
@lanking520 lanking520 merged commit eaacbaf into apache:master Jun 7, 2019
@lanking520
Copy link
Member

@roywei can we get this in 1.5.0 as well?

@zachgk zachgk deleted the scRelUp branch June 7, 2019 18:02
zachgk added a commit to zachgk/incubator-mxnet that referenced this pull request Jun 7, 2019
* Fix Scala release

Add GPG signing to pom.xml
Fix staging target repository

* Fix duplicate xml heading
@zachgk zachgk mentioned this pull request Jun 7, 2019
4 tasks
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Fix Scala release

Add GPG signing to pom.xml
Fix staging target repository

* Fix duplicate xml heading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants