Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1412] Backporting the fix to v1.4.x branch to prevent the crash in naive engine #15154

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

leleamol
Copy link
Contributor

@leleamol leleamol commented Jun 4, 2019

Description

This change prevents the crash that happens due to early destruction of shared pointers during NaiveEngine shutdown. The change is available in master. This PR is backporting the change to v1.4.x branch.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [y] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [y] Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@szha szha merged commit b241c41 into apache:v1.4.x Jun 5, 2019
@leleamol
Copy link
Contributor Author

leleamol commented Jun 5, 2019

Here is the PR in master that added the shared references to NaiveEngine class
#14006
#14006

@leleamol leleamol deleted the naive-engine-fix branch June 10, 2019 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants