Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Python test failures under windows now report the exit code #15147

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

david-seiler
Copy link
Contributor

Description

While working on PR-14617, I hit an obscure Windows-only crash. Adding the $LastExitCode to the error message helped me debug it; a hex-formatted version of that change appears here.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • The only changes are on the error paths for ci/windows/test_*.ps1, so the PR doesn't test all that well. In the first version I've deliberately broken test_py2_gpu.ps1 (see line 27), so we should see that test fail and report an exit code of 0x0. Assuming that behaves as expected, I'll amend the PR to make it pass.

Comments

  • No rush to merge this, I just promised Marco I'd give it its own PR.

@piyushghai
Copy link
Contributor

@david-seiler Thanks for your contributions. Could you look into the CI failure on windows-gpu ?

@mxnet-label-bot Add [pr-awaiting-review, Test]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Test labels Jun 4, 2019
@david-seiler david-seiler force-pushed the windows-errors branch 2 times, most recently from adc3e20 to 0cf5146 Compare June 5, 2019 08:10
@david-seiler
Copy link
Contributor Author

@david-seiler Thanks for your contributions. Could you look into the CI failure on windows-gpu ?

@mxnet-label-bot Add [pr-awaiting-review, Test]

That was the planned failure described in the section under test coverage. My change only touches error paths, so I wanted to prove that the Throw() did the right thing. That worked as expected, you can see the result here:

http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/windows-gpu/branches/PR-15147/runs/2/nodes/115/steps/186/log/?start=0

The latest version should be good to merge; we'll see in an hour or so.

@marcoabreu marcoabreu merged commit 0337451 into apache:master Jun 7, 2019
@david-seiler david-seiler deleted the windows-errors branch June 11, 2019 08:19
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants