Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Relax Visual Studio version constraint in the specialization of dmlc::type_name_helper<DT> for DT=mxnet::Tuple<T> #15144

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Relax Visual Studio version constraint in the specialization of dmlc::type_name_helper<DT> for DT=mxnet::Tuple<T> #15144

merged 3 commits into from
Sep 20, 2019

Conversation

Vigilans
Copy link
Contributor

@Vigilans Vigilans commented Jun 4, 2019 •
edited by zachgk
Loading

Description

Fix #14116, Fix #15143
Description of the content is covered in #15143.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Relax the version constraint of Visual Studio to allow 2015 and later to pass (_MSC_VER > 1900)

@Vigilans
Solve #14116, #15143
ea80bb6 
Relax Visual Studio version constraint in the specialization of `dmlc::type_name_helper<DT>` for `DT=mxnet::Tuple<T>`
@piyushghai
Copy link
Contributor

Thanks for your contributions @Vigilans
@mxnet-label-bot Add[pr-awaiting-review, Backend]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review labels Jun 4, 2019
@vandanavk
Copy link
Contributor

Please add "Fixes #14116" in the PR description to automatically close the issue when the PR is merged

@roywei
Copy link
Member

roywei commented Jul 8, 2019

@Vigilans could you trigger the CI again? thanks!

@Vigilans Vigilans closed this Jul 9, 2019
@Vigilans Vigilans reopened this Jul 9, 2019
@karan6181
Copy link
Contributor

@Vigilans Could you please look into CI failure?

@anirudh2290 @eric-haibin-lin Could you please review this PR? Thanks!

@Vigilans
Copy link
Contributor Author

@karan6181 Now all CI checks have been passed...seems to be the problem of syncing with master.

This was referenced Jul 23, 2019
Open
Open
@piyushghai
Copy link
Contributor

@anirudh2290 Can you review this PR.?

@QueensGambit
Copy link
Contributor

I approve this PR, see #15632.

@JiaoPaner JiaoPaner mentioned this pull request Sep 20, 2019
Closed
@zachgk
Copy link
Contributor

zachgk commented Sep 20, 2019

@QueensGambit Thanks for reviewing. You can actually use the official approve GitHub approve button under Files Changed -> Review Changes -> Approve even if you are not a committer.

@anirudh2290 @junrushao1994 @eric-haibin-lin Can any of you help review this PR?

@zachgk zachgk merged commit d61ed3f into apache:master Sep 20, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
@Vigilans @drivanov
Solve apache#14116, apache#15143 (apache#15144)
4af2a38 
Relax Visual Studio version constraint in the specialization of `dmlc::type_name_helper<DT>` for `DT=mxnet::Tuple<T>`
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@Vigilans @larroy
Solve apache#14116, apache#15143 (apache#15144)
01211c1 
Relax Visual Studio version constraint in the specialization of `dmlc::type_name_helper<DT>` for `DT=mxnet::Tuple<T>`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 anirudh2290 approved these changes

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

Assignees
No one assigned
Labels
Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
9 participants
@Vigilans @piyushghai @vandanavk @roywei @karan6181 @QueensGambit @zachgk @anirudh2290 @marcoabreu