-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Thanks for your contributions @roywei |
@aaronmarkham Can you please help review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some suggested changes for clarity and grammar.
@aaronmarkham @IvyBazan Thanks for the review, I have addressed the comments. |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few spelling nits and a ToC.
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
@aaronmarkham Thanks for the TOC!! it seems working fine here: |
The old TOC that is down here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing my change request...
@IvyBazan Could you please review this PR? Thanks! |
LGTM! |
@aaronmarkham 1.5 is released, this is good to go. We also need to update the website. |
* 1.5.0 news * update news * add news * update news * trigger ci: * fix * address comments * Update NEWS.md Co-Authored-By: Aaron Markham <[email protected]> * Update NEWS.md Co-Authored-By: Aaron Markham <[email protected]> * Update NEWS.md Co-Authored-By: Aaron Markham <[email protected]> * Update NEWS.md Co-Authored-By: Aaron Markham <[email protected]> * Update NEWS.md Co-Authored-By: Aaron Markham <[email protected]>
Description
release notes for 1.5.0 release
Do not merge until vote for 1.5.0 release is passed
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments