Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

1.5.0 news #15137

Merged
merged 12 commits into from
Jul 23, 2019
Merged

1.5.0 news #15137

merged 12 commits into from
Jul 23, 2019

Conversation

roywei
Copy link
Member

@roywei roywei commented Jun 3, 2019

Description

release notes for 1.5.0 release
Do not merge until vote for 1.5.0 release is passed

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@piyushghai
Copy link
Contributor

Thanks for your contributions @roywei
@mxnet-label-bot Add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels Jun 4, 2019
@roywei roywei changed the title [WIP] 1.5.0 news 1.5.0 news Jun 8, 2019
@Roshrini
Copy link
Member

@aaronmarkham Can you please help review this PR?

NEWS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@IvyBazan IvyBazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggested changes for clarity and grammar.

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@roywei
Copy link
Member Author

roywei commented Jun 25, 2019

@aaronmarkham @IvyBazan Thanks for the review, I have addressed the comments.

@IvyBazan
Copy link
Contributor

LGTM!

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few spelling nits and a ToC.

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Show resolved Hide resolved
roywei and others added 5 commits June 27, 2019 09:49
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
@roywei roywei changed the title 1.5.0 news [WIP][DO NOT MERGE]1.5.0 news Jul 5, 2019
@roywei
Copy link
Member Author

roywei commented Jul 5, 2019

This TOC should work... but we might need to remove the old TOC for 1.4.1 (or update it) so there are no conflicts.

@aaronmarkham Thanks for the TOC!! it seems working fine here:
https://github.com/roywei/incubator-mxnet/blob/news/NEWS.md
what conflict are you talking about?

@aaronmarkham
Copy link
Contributor

The old TOC that is down here:
https://github.com/apache/incubator-mxnet/pull/15137/files#diff-8312ad0561ef661716b48d09478362f3R1072
Might be better to always delete the old TOC and put a new one at the top. Of course it'll get super long...

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my change request...

@karan6181
Copy link
Contributor

@IvyBazan Could you please review this PR? Thanks!

@IvyBazan
Copy link
Contributor

LGTM!

@roywei roywei changed the title [WIP][DO NOT MERGE]1.5.0 news 1.5.0 news Jul 19, 2019
@roywei
Copy link
Member Author

roywei commented Jul 19, 2019

@aaronmarkham 1.5 is released, this is good to go. We also need to update the website.

@aaronmarkham aaronmarkham merged commit 858e171 into apache:master Jul 23, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* 1.5.0 news

* update news

* add news

* update news

* trigger ci:

* fix

* address comments

* Update NEWS.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update NEWS.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update NEWS.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update NEWS.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update NEWS.md

Co-Authored-By: Aaron Markham <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants