update LICENSE #15128

roywei · 2019-06-03T00:45:03Z

Description

As suggested in 1.4.1 release dev list discussion, replacing MNIST url to canonical URL. https://lists.apache.org/thread.html/0cb2131f2506661a884f89d8419aba08298cbc50aaeeda06e41e530f@%3Cdev.mxnet.apache.org%3E

and update the license for datasets used in examples.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Feature1, tests, (and when applicable, API doc)
Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

wkcn

LGTM. Thank you for the fix!

roywei · 2019-06-04T16:55:39Z

@zachgk @lanking520 could you help review the license? Thanks!

zachgk · 2019-06-04T18:02:02Z

LICENSE

@@ -276,6 +276,7 @@
          Copyright (c) 2015 by Contributors
          Copyright 1984, 1987, 1992 by Stephen L. Moshier

+    27. CNN Text Classification Example - For details, see example/cnn_text_classification/data_helpers.py


The LICENSE file is more specifically our source release license. It should only refer to things which are bundled as part of the source release (http://www.apache.org/dev/licensing-howto.html). Maybe we could move this to a separate DATASET_LICENSE file?

I'm changing the dataset license link as a comment of the code that downloads it. As these dataset are not bit included in our distribution, and should not be included in top level LICENSE file.

zachgk · 2019-06-04T18:12:41Z

LICENSE

@@ -349,6 +350,19 @@
         Copyright 2012 Continuum Analytics, Inc.


+    =======================================================================================
+    Creative Commons Attribution 4.0 International (CC BY 4.0)


Note that there are 6 different licenses as part of CC BY 4.0 (https://creativecommons.org/licenses/). It is important to know which one because some of them will prevent commercial usage, prevent derivative works, or require others to use the same license.

provided link to exact license statement at the place that downloads it.

zachgk · 2019-06-04T18:19:11Z

tests/nightly/estimator/test_sentiment_rnn.py

@@ -101,7 +101,19 @@ def download_imdb(data_dir='/tmp/data'):
    '''
    Download and extract the IMDB dataset
    '''
-    url = ('http://ai.stanford.edu/~amaas/data/sentiment/aclImdb_v1.tar.gz')
+    # dataset from http://ai.stanford.edu/~amaas/data/sentiment/


While it is good to include the full citation here, also add the information on licensing and copyrights to the README or whatever docs people read which tells them to download the data. The idea is that some of these licenses actually have consequences. For example, we don't want to let commercial users accidentally work with a non-commercial dataset. So, our goal is to make sure that any time we inform users about a dataset, we also explain what legal requirements come with that dataset as well.

There is not license or copy right for this dataset, only citation requriement.

Just say the copyright is whatever person or group seems to have created it. And, say that they require attribution in place of the usual license name (but link to the request)

piyushghai · 2019-06-04T20:04:41Z

Thanks for your contributions @roywei .
@mxnet-label-bot Add [pr-awaiting-review, Licenses]

example/gluon/style_transfer/dataset/download_dataset.py

example/gluon/embedding_learning/get_cub200_data.sh

zachgk · 2019-06-05T21:46:24Z

example/gluon/style_transfer/dataset/download_dataset.py

@@ -26,6 +26,8 @@ def unzip_file(filename, outpath):
        z.extract(name, outpath)
    fh.close()



We need to also put the information below in the corresponding documents. In this case, it would be example/gluon/style_transfer/README.md.

zachgk · 2019-06-05T21:52:46Z

tests/nightly/estimator/test_sentiment_rnn.py

@@ -101,7 +101,19 @@ def download_imdb(data_dir='/tmp/data'):
    '''
    Download and extract the IMDB dataset
    '''
-    url = ('http://ai.stanford.edu/~amaas/data/sentiment/aclImdb_v1.tar.gz')
+    # dataset from http://ai.stanford.edu/~amaas/data/sentiment/


Just say the copyright is whatever person or group seems to have created it. And, say that they require attribution in place of the usual license name (but link to the request)

Co-Authored-By: Zach Kimberg <[email protected]>

roywei · 2019-06-05T23:30:08Z

@zachgk I have added both at source code and README. Also added copyright

* update license * update license * fix typo * update license * add comment * Update example/gluon/style_transfer/dataset/download_dataset.py Co-Authored-By: Zach Kimberg <[email protected]> * Update example/gluon/embedding_learning/get_cub200_data.sh Co-Authored-By: Zach Kimberg <[email protected]> * update license * add license * trigger ci * fix large tensor * update copy right * fix wrong commit * fix * trigger

roywei requested a review from nswamy as a code owner June 3, 2019 00:45

wkcn approved these changes Jun 3, 2019

View reviewed changes

roywei force-pushed the fix_license branch from e13b85f to 912e68d Compare June 4, 2019 06:34

roywei requested a review from szha as a code owner June 4, 2019 06:34

roywei changed the title ~~change data url~~ update LICENSE Jun 4, 2019

zachgk suggested changes Jun 4, 2019

View reviewed changes

marcoabreu added Licenses pr-awaiting-review PR is waiting for code review labels Jun 4, 2019

roywei added 4 commits June 5, 2019 11:10

update license

0e85a52

update license

649f4f2

fix typo

dea665a

update license

1ad7d9b

roywei force-pushed the fix_license branch from a46f02b to 1ad7d9b Compare June 5, 2019 21:01

add comment

acebe1b

zachgk reviewed Jun 5, 2019

View reviewed changes

roywei and others added 3 commits June 5, 2019 15:49

Update example/gluon/style_transfer/dataset/download_dataset.py

3447220

Co-Authored-By: Zach Kimberg <[email protected]>

Update example/gluon/embedding_learning/get_cub200_data.sh

87c3e52

Co-Authored-By: Zach Kimberg <[email protected]>

update license

cd01d16

roywei added 4 commits June 5, 2019 16:39

add license

bd927cd

trigger ci

cae7252

fix large tensor

1027aeb

update copy right

abffb4c

zachgk approved these changes Jun 6, 2019

View reviewed changes

roywei added 3 commits June 6, 2019 11:10

fix wrong commit

5236bf0

fix

6a5eaec

trigger

789b483

eric-haibin-lin merged commit 6c00a5a into apache:master Jun 7, 2019

roywei mentioned this pull request Jun 7, 2019

Backport update LICENSE (#15128) to v1.5.x branch #15174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update LICENSE #15128

update LICENSE #15128

roywei commented Jun 3, 2019 •

edited

Loading

wkcn left a comment

roywei commented Jun 4, 2019

zachgk Jun 4, 2019

roywei Jun 5, 2019

zachgk Jun 4, 2019

roywei Jun 5, 2019

zachgk Jun 4, 2019

roywei Jun 5, 2019

zachgk Jun 5, 2019

piyushghai commented Jun 4, 2019

zachgk Jun 5, 2019

roywei Jun 5, 2019

zachgk Jun 5, 2019

roywei commented Jun 5, 2019

		@@ -26,6 +26,8 @@ def unzip_file(filename, outpath):
		z.extract(name, outpath)
		fh.close()

update LICENSE #15128

update LICENSE #15128

Conversation

roywei commented Jun 3, 2019 • edited Loading

Description

Checklist

Essentials

Changes

Comments

wkcn left a comment

Choose a reason for hiding this comment

roywei commented Jun 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

piyushghai commented Jun 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roywei commented Jun 5, 2019

roywei commented Jun 3, 2019 •

edited

Loading