Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[clojure] fix: image test does not rely on s3 to run #15122

Conversation

Chouffe
Copy link
Contributor

@Chouffe Chouffe commented Jun 1, 2019

Description

image-test relied on S3 to run which makes it impossible for offline use.
The dependency on S3 is removed and a simple cp is performed instead to load the image in the proper tmp directory.

@Chouffe Chouffe requested a review from gigasquid as a code owner June 1, 2019 20:12
Copy link
Contributor

@kedarbellare kedarbellare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kedarbellare kedarbellare merged commit 52f77c9 into apache:master Jun 2, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* [clojure] fix: image test does not rely on s3 to run

* rename `with-image` to `with-file`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants