Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix the cmake cmd with wrong path #15111

Merged
merged 1 commit into from
Jun 11, 2019
Merged

fix the cmake cmd with wrong path #15111

merged 1 commit into from
Jun 11, 2019

Conversation

NeoZhangJianyu
Copy link
Contributor

@NeoZhangJianyu NeoZhangJianyu commented May 31, 2019

Description

The examples of CMake is with wrong path

Before change, you will meet following error print:

CMake Error: The source directory "/path/to/incubator-mxnet/build" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.

After change:

-- The C compiler identification is GNU 7.4.0
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features

Checklist

Essentials

Changes

Document is updated

Comments

Fix the wrong path in cmake cmd.

@NeoZhangJianyu NeoZhangJianyu requested a review from szha as a code owner May 31, 2019 07:54
@abhinavs95
Copy link
Contributor

Thanks for the fix @NeoZhangJianyu

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels May 31, 2019
@pengzhao-intel
Copy link
Contributor

Thanks for the fix.
Could you paste the log before and after the fix?

@NeoZhangJianyu
Copy link
Contributor Author

Thanks for the fix.
Could you paste the log before and after the fix?

Yes, I update the log in issue description.

Copy link
Member

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.

@pengzhao-intel
Copy link
Contributor

pengzhao-intel commented Jun 11, 2019

Thanks for your contribution. Merging now.

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel merged commit 1c3e964 into apache:master Jun 11, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@NeoZhangJianyu NeoZhangJianyu deleted the cmake_fix branch June 24, 2019 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants