Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update float16 tutorial #15107

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Conversation

Ishitori
Copy link
Contributor

Description

Some word smiting on float16 tutorial. Fixed the code by adding imports. Added extra examples how to download the data

@Ishitori Ishitori requested a review from szha as a code owner May 30, 2019 21:33
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ishitori Thanks for the contribution! I noticed there is additional requirement from import tarfile , please add it to docker install list. Also I would like to request run nightly test on tutorial once to make sure this change is passing. It's not tested in PR validation.
Nightly tests has been failing for a long time, and often due to forget to add dependencies in docker or warnings in the code execution (considered as failure in nightly test). Refer to fix in #15039

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [Doc]

@marcoabreu marcoabreu added the Doc label May 31, 2019
@Ishitori
Copy link
Contributor Author

Ishitori commented Jun 7, 2019

@roywei, I completely agree that we should make sure that nightly tests are working. However, this particular tutorial is a part of FAQ section, which is currently not covered by automatic tests. The tests covers only items under tutorials/ folder. I assume the reason for that is that FAQ items may have some incomplete parts of the code, as for example, this one.

I have addressed comments by @vishaalkapoor made in another copy of this PR (closed now).

@thomelane
Copy link
Contributor

@Ishitori can you link to the other PR? Would be good to see comments here.

@Ishitori
Copy link
Contributor Author

@thomelane
Copy link
Contributor

LGTM

@ThomasDelteil ThomasDelteil merged commit e5902ec into apache:master Jun 12, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Update float16 tutorial

* Code review changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants