-
Notifications
You must be signed in to change notification settings - Fork 6.8k
NER example: fix metrics computation #15106
Conversation
Thanks for the fix @WilliamTambellini @mxnet-label-bot add [Example, Python, pr-awaiting-review] |
@@ -93,6 +93,7 @@ def build_vocab(nested_list): | |||
""" | |||
# Build vocabulary | |||
word_counts = Counter(itertools.chain(*nested_list)) | |||
logging.getLogger().info("build_vocab: word_counts=%d" % (len(word_counts))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logging.getLogger().info("build_vocab: word_counts=%d" % (len(word_counts))) | |
logging.info("build_vocab: word_counts=%d", len(word_counts)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szha done
@piyushghai @abhinavs95 @karan6181 for review |
@WilliamTambellini seems that there's one more to fix for the lazy logging (the open comment). |
done |
hum the unix-gpu job failed with build.py: 2019-06-20 17:34:39,235Z CRITICAL Execution of ['/work/runtime_functions.sh', 'unittest_ubuntu_gpu_R'] failed with status: 2 Is that job supposed to pass ? |
@WilliamTambellini I triggered these builds again. |
@szha tks, it's better but now unix-cpu failed. |
@WilliamTambellini is this PR good to go for merge? I see all CI test are passing. |
@szha yes, it was just waiting for CI to pass. Tks. |
Description
NER example: fix metrics computation
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments