Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

NER example: fix metrics computation #15106

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Conversation

WilliamTambellini
Copy link
Contributor

@WilliamTambellini WilliamTambellini commented May 30, 2019

Description

NER example: fix metrics computation

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix metrics computation

Comments

  • this change is backward compatible

@abhinavs95
Copy link
Contributor

Thanks for the fix @WilliamTambellini

@mxnet-label-bot add [Example, Python, pr-awaiting-review]

@marcoabreu marcoabreu added Example pr-awaiting-review PR is waiting for code review Python labels May 30, 2019
@@ -93,6 +93,7 @@ def build_vocab(nested_list):
"""
# Build vocabulary
word_counts = Counter(itertools.chain(*nested_list))
logging.getLogger().info("build_vocab: word_counts=%d" % (len(word_counts)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logging.getLogger().info("build_vocab: word_counts=%d" % (len(word_counts)))
logging.info("build_vocab: word_counts=%d", len(word_counts))

Copy link
Contributor Author

@WilliamTambellini WilliamTambellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szha done

@vandanavk
Copy link
Contributor

@piyushghai @abhinavs95 @karan6181 for review

@szha
Copy link
Member

szha commented Jun 16, 2019

@WilliamTambellini seems that there's one more to fix for the lazy logging (the open comment).

@WilliamTambellini
Copy link
Contributor Author

@WilliamTambellini seems that there's one more to fix for the lazy logging (the open comment).

done

@WilliamTambellini
Copy link
Contributor Author

hum the unix-gpu job failed with
Failed: 1
Warnings: 4
Skipped: 2
Error: Test failures
Execution halted
Makefile:677: recipe for target 'rpkgtest' failed
make: *** [rpkgtest] Error 1

build.py: 2019-06-20 17:34:39,235Z CRITICAL Execution of ['/work/runtime_functions.sh', 'unittest_ubuntu_gpu_R'] failed with status: 2

Is that job supposed to pass ?

@szha
Copy link
Member

szha commented Jun 21, 2019

@WilliamTambellini I triggered these builds again.

@WilliamTambellini
Copy link
Contributor Author

@szha tks, it's better but now unix-cpu failed.

@karan6181
Copy link
Contributor

@WilliamTambellini is this PR good to go for merge? I see all CI test are passing.

@szha szha merged commit 9d859c8 into apache:master Jul 21, 2019
@WilliamTambellini
Copy link
Contributor Author

@szha yes, it was just waiting for CI to pass. Tks.

anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Example pr-awaiting-review PR is waiting for code review Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants