Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

bump up version from 1.5.0 to 1.6.0 on master #15072

Merged
merged 5 commits into from
Jul 24, 2019
Merged

bump up version from 1.5.0 to 1.6.0 on master #15072

merged 5 commits into from
Jul 24, 2019

Conversation

roywei
Copy link
Member

@roywei roywei commented May 25, 2019 •
edited
Loading

Description

bump up version from 1.5.0 to 1.6.0 on master
bump up scala README.md 1.3.1 to latest stable 1.4.0

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

iblislin
iblislin reviewed May 27, 2019
View reviewed changes
julia/NEWS.md Outdated Show resolved Hide resolved
@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label May 30, 2019
@roywei roywei force-pushed the bump_version branch 2 times, most recently from 640c29e to 5edd2ab Compare May 31, 2019 05:04
@piyushghai
Copy link
Contributor

@roywei Can you resolve the merge conflicts in this PR ?

@roywei
Copy link
Member Author

roywei commented Jul 8, 2019

@mxnet-label-bot add [pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Jul 8, 2019
@eric-haibin-lin eric-haibin-lin merged commit 01fae12 into apache:master Jul 24, 2019
@zachgk zachgk mentioned this pull request Jul 25, 2019
Merged
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@roywei
bump up version from 1.5.0 to 1.6.0 on master (apache#15072)
901f860 
* bump up version

* address comments

* trigger

* trigger
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iblislin iblislin iblislin left review comments

@szha szha szha left review comments

@gigasquid gigasquid Awaiting requested review from gigasquid gigasquid is a code owner

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review pr-work-in-progress PR is still work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@roywei @abhinavs95 @piyushghai @iblislin @szha @eric-haibin-lin @marcoabreu