Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix imresize interp docs #15066

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

aaronmarkham
Copy link
Contributor

Description

Fixes #14993

I just flipped the order of the interp param docs according to what @zhouhang95 noted in #14993.

@aaronmarkham aaronmarkham requested a review from szha as a code owner May 24, 2019 21:19
@karan6181
Copy link
Contributor

@mxnet-label-bot add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels May 24, 2019
@aaronmarkham
Copy link
Contributor Author

@zhouhang95 Does this PR look good to you? I need a couple of approvals before merging it.

@zhouhang95
Copy link

My PR is right. MXNet use opencv as its image process lib. The arg is in accordance with the opencv arg.

Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aaronmarkham aaronmarkham merged commit b2e6dac into apache:master Jun 12, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The discription of function mxnet.image.imresize is wrong.
6 participants