Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Dependency Update] Dependency update doc #15045

Merged
merged 6 commits into from
Aug 6, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented May 22, 2019

Description

document dependency update

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@stu1130 stu1130 requested a review from szha as a code owner May 22, 2019 21:03
@stu1130 stu1130 changed the title Dependecy update doc [Dependency Update] Dependency update doc May 22, 2019
@karan6181
Copy link
Contributor

@mxnet-label-bot add [Doc, pr-awaiting-review]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review labels May 23, 2019
@stu1130 stu1130 force-pushed the dependecy_update_doc branch 4 times, most recently from 0185d13 to 9fca137 Compare May 31, 2019 06:44
@vandanavk
Copy link
Contributor

@marcoabreu @perdasilva @aaronmarkham for review

@karan6181
Copy link
Contributor

@marcoabreu @perdasilva @aaronmarkham Gentle Ping!

tools/dependencies/README.md Outdated Show resolved Hide resolved
# Take CUDA 10 for example
wget https://developer.nvidia.com/compute/cuda/10.0/Prod/local_installers/cuda_10.0.130_410.48_linux
chmod +x cuda_10.0.130_410.48_linux && sudo ./cuda_10.0.130_410.48_linux
# Installation except:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type fixed

### CUDA, cuDNN, NCCL
#### 1. Environment Setup
```
# Take Ubuntu 16.04 for example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could move this out of the code block and introduce what is going on here.

tools/dependencies/README.md Show resolved Hide resolved
tools/dependencies/README.md Outdated Show resolved Hide resolved
```
# Download the ImageNet on http://image-net.org/download and make record file
# Install prerequisite package
pip2 install psutil --user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pip2?

Copy link
Contributor Author

@stu1130 stu1130 Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our benchmark script is written in python2 and not compatible with python3


# Install python frontend
cd python
pip3 install -e . --pre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just pip? Let users to pick the right version (maybe thorugh viurtualenv)

# Wait for 10 - 30 mins, you will find libmxnet.so under the incubator-mxnet/lib

# Install python frontend
cd python
Copy link
Contributor

@apeforest apeforest Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified by pip install -e python

pip install -e . --pre
# Test MXNet
>>> import mxnet as mx
>>> mx.nd.ones((2, 5) ctx=mx.gpu(0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can replace this test using the mxnet.runtime.feature_list()

# Clone the testing script
git clone https://github.com/rahul003/deep-learning-benchmark-mirror.git
# command
python2 benchmark_runner.py --framework mxnet --metrics-policy metrics_parameters_images_top_1 --task-name metrics_parameters_images_top_1 --metrics-suffix test --num-gpus 8 --command-to-execute 'python mxnet_benchmark/train_imagenet.py --use-rec --batch-size 128 --dtype float32 --num-data-workers 40 --num-epochs 3 --gpus 0,1,2,3,4,5,6,7 --lr 0.4 --warmup-epochs 5 --last-gamma --mode symbolic --model resnet50_v1b --rec-train /home/ubuntu/data/train-passthrough.rec --rec-train-idx /home/ubuntu/data/train-passthrough.idx --rec-val /home/ubuntu/data/val-passthrough.rec --rec-val-idx /home/ubuntu/data/val-passthrough.idx' --data-set data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This benchmark AI flow is outdated and I think it's also not public. Why not just run training script from example directly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe use mnist as an example here. ImageNet is too big.


The dependencies could be categorized by several groups: BLAS libraries, CPU-based performance boost library, i.e. MKLDNN and GPU-based performance boosting library including CUDA, cuDNN, NCCL. and others including OpenCV, Numpy, S3-related, PS-lite dependencies. The list below shows all the dependencies and their version. Except for CUDA, cuDNN, NCCL which the user is required to install on their environments, we statically link those dependencies into libmxnet.so when we build PyPi package. By doing this, the user can take advantage of these dependencies without being worry about it.

| Dependencies | MXNet Version |
Copy link
Contributor

@apeforest apeforest Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reword this? It's not MXNet version, but version of each package.

Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment. otherwise LGTM. thanks for your contribution!

@aaronmarkham
Copy link
Contributor

@stu1130 Did you want to make any further updates to this?

@stu1130
Copy link
Contributor Author

stu1130 commented Aug 6, 2019

@aaronmarkham I think it's good to go

@aaronmarkham aaronmarkham merged commit 51c07e5 into apache:master Aug 6, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* first draft

* 2nd draft

* complete the draft

* capitalize the comment

* address the comment

* address comment
@stu1130 stu1130 deleted the dependecy_update_doc branch January 10, 2020 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants