Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

REAME MTCNN Link URL Error in original website #15020

Merged
merged 15 commits into from
Jul 4, 2019
Merged

Conversation

sunrongda
Copy link
Contributor

Description

(Brief description on what this PR is about)
I found that the original mtcnn website disappeared, and I added the new author's website.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@sunrongda sunrongda requested a review from szha as a code owner May 21, 2019 07:12
@karan6181
Copy link
Contributor

@mxnet-label-bot add [Doc, Example, Python, pr-awaiting-review]

@abhinavs95
Copy link
Contributor

@sunrongda Could you trigger the CI again?

@sunrongda
Copy link
Contributor Author

@abhinavs95 Please help review

@piyushghai
Copy link
Contributor

@mxnet-label-bot Update [Doc, pr-awaiting-merge, Python]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed Example pr-awaiting-review PR is waiting for code review labels Jun 7, 2019
example/README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@sunrongda sunrongda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkcn。 The author of MTCNN model is Kaipeng Zhang.but,https://github.com/kpzhang93 is Kaipeng Zhang‘s new github link 。the old link https://github.com/pangyupo Invalid

example/README.md Outdated Show resolved Hide resolved
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunrongda
Sorry that I reply late.
I have updated the link.
Thanks for your contribution!

example/README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
@wkcn wkcn merged commit 8ebaa5c into apache:master Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-merge Review and CI is complete. Ready to Merge Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants