Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Flaky Test] Disables flaky test_l2_normalization #15006

Merged
merged 1 commit into from
May 21, 2019

Conversation

perdasilva
Copy link
Contributor

Description

Disables flaky test_l2_normalization (see #15004).

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@pinaraws
Copy link

@mxnet-label-bot add[CI, pr-awaiting-review]

@marcoabreu marcoabreu added CI pr-awaiting-review PR is waiting for code review labels May 20, 2019
@szha szha merged commit 91e8115 into apache:master May 21, 2019
@zachgk
Copy link
Contributor

zachgk commented May 23, 2019

@perdasilva For temporarily dealing with flaky tests, it is probably better to specify a fixed seed (see https://github.com/zachgk/incubator-mxnet/blob/master/tests/python/unittest/common.py#L117) rather than disable the test completely

@perdasilva
Copy link
Contributor Author

@zachgk good idea! I'll try to do that in the future. I'll also spread the word.

@perdasilva perdasilva deleted the disable_flaky_l2_normalization_test branch May 24, 2019 05:39
@perdasilva
Copy link
Contributor Author

@zachgk, @marcoabreu claims this was the procedude in the past. But it made flaky test fixes fall in priority, since this creates no sense of urgency... maybe you would like to bring this up as a topic for discussion on the mailing list?

@szha
Copy link
Member

szha commented May 24, 2019

@zachgk @perdasilva FYI just in case you aren't aware, we used to mark tests with fixed seed as issues to fix. #11726

@szha
Copy link
Member

szha commented May 24, 2019

And here's the guideline on fixing flaky tests: https://cwiki.apache.org/confluence/display/MXNET/Fixing+Flaky+Tests

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants