Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Flaky Test] Disables flaky test_bilinear_resize_op #15000

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 20, 2019

Description

Disables flaky test_bilinear_resize_op (see #14902).

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@pinaraws
Copy link

@mxnet-label-bot add[CI, pr-awaiting-review]

@marcoabreu marcoabreu added CI pr-awaiting-review PR is waiting for code review labels May 20, 2019
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking the PR from merging for now, experimenting with a reasonable atol value on my end, will get back in a few hours.

@haojin2
Copy link
Contributor

haojin2 commented May 21, 2019

@perdasilva True fix for this test in #15011, the original atol value was too low.

@perdasilva
Copy link
Contributor Author

Nice one, thank you! @haojin2

@perdasilva
Copy link
Contributor Author

Closing in favour of #15011

@perdasilva perdasilva closed this May 21, 2019
@perdasilva perdasilva deleted the disabled_flaky_test_bilinear_resize_op branch May 21, 2019 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants