Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Revert "[Dependency Update] Upgrade cuDNN & NCCL (#14884)" #14910

Merged
merged 1 commit into from
May 8, 2019

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 7, 2019

This reverts commit 0255dd6.

Description

Reverting #14884 as the built artifact does not pass the test pipeline (due to cuDNN 7.5 issues).
@stu1130 please check if it's ok.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@perdasilva perdasilva requested a review from szha as a code owner May 7, 2019 18:22
@stu1130
Copy link
Contributor

stu1130 commented May 7, 2019

Thanks @perdasilva Once we have CI pass with CUDA 10 + cuDNN 7.5.1, I will raise the PR again

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Build]

@marcoabreu marcoabreu added Build pr-awaiting-review PR is waiting for code review labels May 7, 2019
@szha szha merged commit 0ddef13 into apache:master May 8, 2019
@perdasilva perdasilva deleted the revert_pr_14884 branch May 8, 2019 06:00
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants