Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add STL checks via -D_GLIBCXX_ASSERTIONS in debug mode #14896

Merged
merged 3 commits into from
May 21, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented May 6, 2019

Description

Add checks for C++ STL containers in DEBUG builds.

This important flag will check for correctness when using STL containers such as range checks and other situations that can cause out of bound errors and undefined behaviour while running in debug mode. It will make our code more resilient and help us catch bugs when running in Debug.

It doesn't affect release builds.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy larroy requested a review from szha as a code owner May 6, 2019 19:26
@larroy
Copy link
Contributor Author

larroy commented May 6, 2019

@mxnet-label-bot add [Build,CMake,Make]

@marcoabreu marcoabreu added Build CMake CMake related bugs/issues/improvements labels May 6, 2019
@larroy
Copy link
Contributor Author

larroy commented May 14, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label May 14, 2019
@larroy
Copy link
Contributor Author

larroy commented May 21, 2019

@szha

@szha szha merged commit 789a6be into apache:master May 21, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Add STL checks via -D_GLIBCXX_ASSERTIONS in debug mode

* Also add to Makefile

* Fix warning (fpermissive) sleep definition not available
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build CMake CMake related bugs/issues/improvements pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants